Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Columns in string pruning (#32626) (#32721) #32926

Closed
wants to merge 1 commit into from
Closed

planner: Columns in string pruning (#32626) (#32721) #32926

wants to merge 1 commit into from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 8, 2022 •
edited
Loading

cherry-pick #32721 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/32926

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/32926:release-5.3-7bf5e4e23ea0

What problem does this PR solve?

Issue Number: close #32626

Problem Summary:

What is changed and how it works?

Only int and time type of columns was enabled to prune partitions in RANGE COLUMNS IN conditions.

This also enables String type columns

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Enable partition pruning for RANGE COLUMNS partitioning on IN conditions and string type columns

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 8, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 8, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.3-cherry-pick labels Mar 8, 2022
@ti-srebot ti-srebot added this to the v5.3.1 milestone Mar 8, 2022
@ti-srebot
Copy link
Contributor Author

@mjonss you're already a collaborator in bot's repo.

@mjonss
Copy link
Contributor

mjonss commented Mar 9, 2022

Blocked by #31864 (needed to resolve merge conflict, depending on the support for IN partition pruning)

@VelocityLight
Copy link

This pull request is closed because the related issue is triaged "Won't Fix".
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

@mjonss mjonss deleted the release-5.3-7bf5e4e23ea0 branch September 22, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees

@mjonss mjonss

Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.3-cherry-pick
Projects
None yet
Milestone
v5.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @ti-chi-bot @mjonss @VelocityLight